-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for errors in the "array_ptr" interfaces to some libc functions declared in checkedc_extensions.h, and removal of the conditional in the snprintf declaration in stdio_checked.h #456
Conversation
|
||
#pragma CHECKED_SCOPE on | ||
|
||
#include <stddef.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these headers be listed alphabetically?
include/checkedc_extensions.h
Outdated
@@ -6,6 +6,7 @@ | |||
|
|||
#include <stdlib_checked.h> | |||
#include <string_checked.h> | |||
#include <stdarg.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these headers be listed alphabetically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Could you please add a title describing the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
This PR contains fixes for issues #449 and #450. They are, in brief:
strncmp_array_ptr
asextern inline
,snprintf_array_ptr
, andsnprintf
(i.e. the argumentn
) and the bounds declaration for the first argument ofsnprintf
(i.e., the arguments
) when n == 0.